martin trieu
martin trieu
@scwhittle any more comments here? Thank you!
added drain (fail work and clear queues) when we close the SEWorkCommitter will need this for direct path. in non direct path mode we would never call stop (except when...
test failures should be fixed in https://github.com/apache/beam/pull/30572 since it removes arbitrary waiting from the tests (replaced with countdownlatch as event triggers)
wooh! looks good
Thanks! I'll run it and circle back @Abacn is there anyway I can run it in the same environment as GitHub actions? Or simulate the different loads?
running this command locally ``` :runners:google-cloud-dataflow-java:worker:test --tests "org.apache.beam.runners.dataflow.worker.windmill.client.grpc.StreamingEngineClientTest" ```
``` :runners:google-cloud-dataflow-java:worker:test --tests "org.apache.beam.runners.dataflow.worker.windmill.client.grpc.StreamingEngineClientTest" ``` was successful @Abacn
@scwhittle ready for another look thanks!
assign set of reviewers
ready for another look @scwhittle I went with the sort of a SteppedBuilder https://github.com/google/auto/blob/main/value/userguide/builders-howto.md#-create-a-step-builder approach for passing the ProcessingContext out of GrpcDirectGetWorkStream. The receiver just has to `setProcessWorkFn` and then...