martin trieu
martin trieu
ready for another look @scwhittle
Run Java Precommit
> Looks like this assert failed in test: > > https://github.com/apache/beam/blob/0bce6d7a834c521a3d3043ab9377fcd2f2e16f0a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java#L3355 > > Could be flaky if doesn't wait enough to get commit or it could be an indication that...
will take a look today
have a potential fix https://github.com/apache/beam/pull/30322
R: @scwhittle still working on the tests but curious about initial thoughts. also opted to offload the thread management to executors instead of using raw threads. This may allow us...
@scwhittle ready for a look! thanks
ready for another look @scwhittle thanks!
presubmit failure is due to flaky test (working on a PR to fix) and not related.
test flakiness attempted to be fixed here #30572