beam icon indicating copy to clipboard operation
beam copied to clipboard

use work processing context in work processing

Open m-trieu opened this issue 1 year ago • 6 comments

Add work processing context

R: @scwhittle


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

m-trieu avatar May 01 '24 15:05 m-trieu

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar May 01 '24 16:05 github-actions[bot]

assign set of reviewers

m-trieu avatar May 02 '24 09:05 m-trieu

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @johnjcasey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 02 '24 09:05 github-actions[bot]

ready for another look @scwhittle

I went with the sort of a SteppedBuilder https://github.com/google/auto/blob/main/value/userguide/builders-howto.md#-create-a-step-builder approach for passing the ProcessingContext out of GrpcDirectGetWorkStream. The receiver just has to setProcessWorkFn and then build.

m-trieu avatar May 15 '24 00:05 m-trieu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.42%. Comparing base (bcac88b) to head (2109108). Report is 73 commits behind head on master.

:exclamation: Current head 2109108 differs from pull request most recent head 3c0702a

Please upload reports for the commit 3c0702a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #31148   +/-   ##
=========================================
  Coverage     71.42%   71.42%           
  Complexity     1474     1474           
=========================================
  Files           909      909           
  Lines        113707   113707           
  Branches       1076     1076           
=========================================
  Hits          81217    81217           
  Misses        30471    30471           
  Partials       2019     2019           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 19:05 codecov[bot]

Reminder, please take a look at this pr: @johnjcasey

github-actions[bot] avatar May 23 '24 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @johnjcasey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 28 '24 12:05 github-actions[bot]