beam icon indicating copy to clipboard operation
beam copied to clipboard

Add DirectCommitWorkStream for direct path

Open m-trieu opened this issue 1 year ago • 1 comments

Add a DirectCommitWorkStream that has a self contained commit queue, and commit thread. Callers will call queueCommit on the stream, and and commits will be batched and sent to windmill internally.

R: @scwhittle

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

m-trieu avatar Feb 08 '24 08:02 m-trieu

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Feb 08 '24 08:02 github-actions[bot]

Reminder, please take a look at this pr: @lostluck

github-actions[bot] avatar Feb 21 '24 12:02 github-actions[bot]

@scwhittle ready for another look thanks!

m-trieu avatar Feb 21 '24 22:02 m-trieu

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Feb 28 '24 12:02 github-actions[bot]

Reminder, please take a look at this pr: @lostluck

github-actions[bot] avatar Mar 14 '24 12:03 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Mar 19 '24 12:03 github-actions[bot]

R: @scwhittle

lostluck avatar Mar 25 '24 22:03 lostluck

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Mar 25 '24 22:03 github-actions[bot]