Marin Peko comments

Results 11 comments of


                                            Marin Peko

Counter Not Counting

I suppose this counter implementation won't work when compiled with GCC 8 and above. Similar implementation works for me in case of all lower GCC versions.

Update API

> Thoughts on this? I have put comments to the code. Please take a look at those.

Update API

> Just realizing..maybe you left comments but they didn't post correctly because I cannot see any comments on the PR Yeah, I always forget to submit comments. I am not...

Additional methods is_set, unset

Hey, First of all, glad you liked the library. Your proposal seems reasonable to me. You can open a PR. We'll need to release new version, possibly 2.0, of the...

Additional methods is_set, unset

@EliSchleifer how is it going? Let me know if I should do this change instead of you! Thanks

Additional methods is_set, unset

ok, perfect

array bounds warning in include/tins/pdu_option.h

Hi there, Can you please post full warning message you get? Thank you

adding layer 7 protocol

I believe this library is bounded up to the transport layer and, in the close future, won't be dealing with application layer protocols.

Consider using a ring buffer for the SPSC buffer

I would suggest using a spin-lock here instead of a regular `std::mutex`. It might be faster even without changing the `std::vector` to ring buffer. If you agree, I can take...

Consider using a ring buffer for the SPSC buffer

Thanks for thorough reply! I'll take a look at the benchmark and try to experiment a bit with it, and maybe implement a new benchmark at the queue level. I...