Additional methods is_set, unset

[EliSchleifer]

Would you be open to a PR that aliased the verbs

unset and is_set. The class is super cool, but contains and remove feel like STL container verbs, and if this is a bitset - I don't need to know the impl underneath. I'd like the verbs to be binary set/unset and is_set.

Thoughts?

[m-peko]

Hey,

First of all, glad you liked the library. Your proposal seems reasonable to me. You can open a PR. We'll need to release new version, possibly 2.0, of the library since this is a breaking change but that's my part of the job.

Anyway, open PR, I'll review it and that's it! Glad to have you contributing!

Thanks.

[m-peko]

@EliSchleifer how is it going? Let me know if I should do this change instead of you! Thanks

[EliSchleifer]

I can code it up. Probably get you a PR in a couple fays

---

From: Marin Peko @.> Sent: Tuesday, September 7, 2021 1:11:42 PM To: m-peko/bitflags @.> Cc: Eli Schleifer @.>; Mention @.> Subject: Re: [m-peko/bitflags] Additional methods is_set, unset (#23)

@EliSchleiferhttps://github.com/EliSchleifer how is it going? Let me know if I should do this change instead of you! Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/m-peko/bitflags/issues/23#issuecomment-914592067, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJVCPTBKM4ZPXMD3EPYOHLUAZWX5ANCNFSM5CXNZMZQ.

[m-peko]

ok, perfect

[EliSchleifer]

Posted a PR https://github.com/m-peko/bitflags/pull/24