Update API

[EliSchleifer]

Renames contains > is_set remove(Flag) > clear(Flag) is_all > all_set

I think I found a bug in the All code. The All() method I believe is returning all bits, not just defined flags. I updated the test to show this problem. Wasn't sure exactly how to fix it and figured you'd have thoughts.

I disabled the broken test.

Also didn't update documentation. DIdn't want to churn until you were good with the API changes.

[codecov-commenter]

Codecov Report

Merging #24 (db9de38) into master (a70ba82) will decrease coverage by 9.42%. The diff coverage is 72.72%.

@@             Coverage Diff             @@
##            master      #24      +/-   ##
===========================================
- Coverage   100.00%   90.57%   -9.43%     
===========================================
  Files            2        2              
  Lines          122      138      +16     
===========================================
+ Hits           122      125       +3     
- Misses           0       13      +13     

Impacted Files	Coverage Δ
tests/src/bitflags_test.cpp	81.42% <57.14%> (-18.58%)	:arrow_down:
include/bitflags/bitflags.hpp	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a70ba82...db9de38. Read the comment docs.

[EliSchleifer]

Thoughts on this?

[m-peko]

Thoughts on this?

I have put comments to the code. Please take a look at those.

[EliSchleifer]

Just realizing..maybe you left comments but they didn't post correctly because I cannot see any comments on the PR

[m-peko]

Just realizing..maybe you left comments but they didn't post correctly because I cannot see any comments on the PR

Yeah, I always forget to submit comments. I am not working with Github on a daily basis.