Leighton Chen
Leighton Chen
Can we just make `force_flush` a no-op in the base class and not make it an abstract method? That way we can still assume all exporters have the method but...
@srikanthccv > Do you know how base classes are divided into abstract classes that must be implemented vs nop to be overridden? Good question. I'm not sure about the Pythonic...
@aabmass Does this apply to some of the exporters that we own? Let's say, Prometheus? Also how would exporter authors even know about this requirement during implementation? Should we take...
Yes entrypoint style. I don't believe someone can configure a custom sampler with an env var.
@trivikr Sure, feel free to create a PR for this.
@trask Will be approving after the `rc` case has been confirmed to work.
@trask I'm testing this in my local repository. For the two PRs that are generated from `prepare-release-branch` workflow, for the second pr that updates the version in main from `1.12.0rc2-dev`...
@trask Just to verify, I performed the `prepare-release-branch` workflow one more time after the previous run above, and the first PR that merges into the release branch changes the version...
@trask > Also I notice that your prerelease versions don't follow semver (e.g. 1.12.0rc1 instead of 1.12.0-rc1), not sure if that's a python thing, or if you'd like to change...
@trask > So I'm thinking it makes sense to remove the -dev stuff at least for now. I think adding `dev` is a decision made by the Python SIG because...