Leighton Chen

Results 338 comments of Leighton Chen

> Thanks for reviewing @tammy-baylis-swi, I looked into the API as well, Logger "emit" is actually the expected method name, on_emit is only applicable to LogRecordProcessors, I could be missing...

@OS-joaocastilho Gentle ping on this issue. Could you respond to the above ask on how to reproduce this? Perhaps the issue has already been addressed.

Doesn't this fall under the support category of log telemetry being collected from the api/sdk itself, which is undesired? Our recommendation for users is to not use the root logger...

> Good point, and if I change the bottom of the example to this then there is no RecursionError: Is [this pr](https://github.com/open-telemetry/opentelemetry-python/pull/4088) still needed in that case?

Superceded by https://github.com/open-telemetry/opentelemetry-python/pull/4053

It seems like the underlying issue is the fact that you have configured your telemetry collection to collect logs on the api/sdk itself, which is not the intended usage. The...

I believe [java](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/log4j) already uses this convention for different logging libraries. Happy to discuss this in the SIG @aabmass