Leighton Chen

Results 327 comments of Leighton Chen

>No worries, in that case I can keep the existing cap and only require 3.7+ in CI/CD. How does that sound? sgtm

@ofek Question for the future: If we wanted to update [opentelemetry-instrumentation](https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/setup.cfg#L53) to use `pyproject.toml`, according to [PEP621](https://peps.python.org/pep-0621/): > Build back-ends MUST raise an error if the metadata defines a [project.entry-points.console_scripts]...

@srikanthccv @ocelotl Looks like Github is expecting for the Python3.6 test to run to pass status checks but we removed them from the build matrix in this PR. Should we...

@yurishkuro Are you referring to basic usage of OpenTracing or OpenTelemetry in general?

The docs for instrumentation libraries exists [here](https://opentelemetry-python-contrib.readthedocs.io/en/latest/index.html). Is there something missing that you would like to see?

Part of this effort: https://github.com/open-telemetry/opentelemetry-python/issues/2319

@srikanthccv trace/metrics spec don't say anything about a `flush` method but we have `force_flush` defined in `TracerProvider` and `MeterProvider`? Was there a reason to not be consistent in our language...

@jha-hitesh Any idea why the detaching the context would be throwing an exception? We wouldn't want an instrumentation to error out on detaching the context anyways. Maybe make the change...

@sihrc Does this not seem like the instrumentation itself has a bug in it? (in which `detach` is actually called incorrectly)