Luke Bakken

Results 314 comments of Luke Bakken

Why should `shellcheck` flag a script that is doing what you tell it to do? How could this case be detected generally? `set +x` is a perfectly valid thing to...

Thanks for the detailed explanation. @SuperSandro2000 will appreciate it as well. I'm glad I didn't have to debug a failing script due to `set +x` being the last statement in...

@dcarwin-pivotal @michaelklishin I confirmed just now that this issue does not apply to RabbitMQ 3.10.6 (tested with Erlang 25.0.3).

Thanks @bording, I'll find time to check this out. Have a good weekend.

@kjnilsson the value for `module` here is for the old classic queue when the new quorum one is created and then published to on `secondChannel`: https://github.com/rabbitmq/rabbitmq-server/blob/master/deps/rabbit/src/rabbit_queue_type.erl#L573-L575

@bording I'll do some tests to confirm, but my theory is that, without the `BasicGet`, the second channel has no knowledge of what kind of queue it's dealing with. Deleting...

I agree with @dumbbell that the code should handle both "v1" and "v2" versions of the records, eliminating the need for a transformation phase.