publish-nuget icon indicating copy to clipboard operation
publish-nuget copied to clipboard

Collaborators are welcome

Open brandedoutcast opened this issue 2 years ago β€’ 9 comments

As mentioned in this comment I was busy with handling stuff happening in my life & away from GitHub. I see there are a bunch of open issues & apologies for the inconvenience caused

I may or may not actively contribute to this action so I'm willing to hand it over & RabbitMQ seems to be interested so I'm awaiting their response for now. Once added collaborators should be able to decide on what to do with open issues & PRs

brandedoutcast avatar May 05 '22 10:05 brandedoutcast

Hi @brandedoutcast,

We've got a couple options -

  • Add myself and @Gsantomaggio as admins to this repo.
  • See if we can get this project accepted into https://github.com/dotnet or https://github.com/actions. My guess is their response would be "just use dotnet commands".

I think @Gsantomaggio and I have time to at least address the issue backlog here and publish a new release.

lukebakken avatar May 05 '22 14:05 lukebakken

Great, thanks for the help. Sent invites πŸš€

brandedoutcast avatar May 05 '22 14:05 brandedoutcast

Got it! I'll find some time soon to check this project out and figure out next steps.

lukebakken avatar May 05 '22 21:05 lukebakken

Having this action use only .NET commands is an option as well too, with that then they can ship their nuget.config file in their repo and it should be used automatically. I done this in my build-dotnet action (and also I needed an action that would install .NET daily builds so I also made setup-latest-dotnet).

Alternatively projects could migrate to my build-dotnet action too, it’s publish is opt-in I believe if I remember correctly.

AraHaan avatar May 05 '22 22:05 AraHaan

Alternatively projects could migrate to my build-dotnet action too

@AraHaan would you mind pointing out where that is?

lukebakken avatar May 06 '22 22:05 lukebakken

Sure, it's at https://github.com/Elskom/build-dotnet/

AraHaan avatar May 06 '22 23:05 AraHaan

It seems like the best path forward for this project is to direct people to alternatives:

  • https://github.com/alirezanet/publish-nuget
  • https://github.com/Elskom/build-dotnet
  • Just use dotnet commands. We have adopted this method here - https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/main/.github/workflows/publish-nuget.yaml

@brandedoutcast I appreciate you adding myself and @Gsantomaggio to this project. I would like to update the README.md with instructions for alternatives, close issues and pull requests, and then archive this project, ensuring that it's removed from the GH actions marketplace.

lukebakken avatar May 18 '22 21:05 lukebakken

I would rather just not archive it, so that way when they look up the action in marketplace they will see the alternatives to use instead and edit the code to throw an error when they use this action to use those alternatives.

This way developers who do not always check the marketplace can still get the notification.

AraHaan avatar May 19 '22 01:05 AraHaan

Great idea.

lukebakken avatar May 19 '22 01:05 lukebakken