Luke Bakken

Results 314 comments of Luke Bakken

Thank you for your continued contributions. I just returned to work after some PTO, and @Gsantomaggio is out for a bit. We'll get to this when we can!

@ricsiLT thanks for your patience, I'm reviewing this today.

@Gsantomaggio when you get back, let's discuss the remaining test failure. When running the `ConsumeAfterKillConnectionShouldContinueToWork` test we can see that many connections are killed at the end of the test....

@michaelklishin I'll check that out, thanks. @dumbbell I still got the encoding error with the fix for the output of `rabbitmq-env-conf.bat`. I'll see if I can figure out how that...

@michaelklishin that bug is fixed. `[]` was incorrectly being passed as options to `thoas`.

Thanks @dumbbell. I will continue reviewing our use of `list_to_binary/1` to see if there are other places that should be updated. I will also test using the data given in...

Currently testing with `RABBITMQ_BASE` set to `C:\Users\bakkenl\Евгений`

Aha! ``` 2022-09-21T09:58:43.174000-07:00 info: FORMATTER CRASH: {"Stopping message store for directory '~s'",[[99,58,47,85,115,101,114,115,47,98,97,107,107,101,110,108,47,1045,1074,1075,1077,1085,1080,1081,47,100,98,47,114,97,98,98,105,116,64,98,97,107,107,101,110,108,45,122,48,49,45,109,110,101,115,105,97,47,109,115,103,95,115,116,111,114,101,115,47,118,104,111,115,116,115,47,57,69,82,72,66,81,72,57,52,72,52,83,54,89,55,68,90,66,49,77,88,73,78,67,48,47,109,115,103,95,115,116,111,114,101,95,112,101,114,115,105,115,116,101,110,116]]} ```

Running into cuttlefish errors as well when setting configuration paths using unicode: [rabbitmq.conf.txt](https://github.com/rabbitmq/rabbitmq-server/files/9618964/rabbitmq.conf.txt)

OK to keep the scope reasonable for this PR, I think I will deal with the format crash above, and leave the other unicode issues to the future, since I...