Luigi Pinca

Results 330 comments of Luigi Pinca
trafficstars

I don't use TypeScript so any help is appreciated. Feel free to open PRs to improve the type definitions.

I know it's not the same and we should add release notes but for now you can use comparison between two tags. For example `https://github.com/MONEI/Shopify-api-node/compare/2.13.0...2.14.0`.

@frandiox the only breaking change is the minimum Node.js version. `shopify-api-node@3` requires Node.js >= 10.

Does it work without it? What is the returned status code?

The `autoLimit` option is ignored when using the GraphQL API. This is documented here https://github.com/MONEI/Shopify-api-node#shopifycalllimits

Because the rate limiting method is different. Rate limiting for the REST API is based on the token bucket algorithm and we use https://github.com/lpinca/stopcock. This does not work for the...

> However fact that rate limit is different doesn't mean package should not support graphql case. No one said there should be no support for it. It is not implemented.

The existing API is for `GET /admin/api/2020-10/events.json`. There is no support for events of a specific resource. This is a duplicate of https://github.com/MONEI/Shopify-api-node/issues/329.

Yes but the same is valid also for other resources. From the documentation: > Events are generated by the following resources: > > - Articles > - Blogs > -...

Yes, events are like metafields but [`owner_resorce`](https://github.com/MONEI/Shopify-api-node#metafields) and [`owner_id`](https://github.com/MONEI/Shopify-api-node#metafields) do not work for events so I see no other way.