Luigi Pinca

Results 363 comments of Luigi Pinca

> Why do this? 1. The library was designed before "serverless" was a thing. 1. The library was designed for server-side usage. 1. Only pay for what you use. There...

No plans at the moment. Lazy requires are the only thing users sometimes complain about due to bundling issues, so perhaps they can be removed in the next major version....

The field used to check for errors is `errors`: https://github.com/MONEI/Shopify-api-node/blob/c949c7d28c4d701283dcf806060dc0cc20e607e7/index.js#L236-L246

You can probably get more details by logging `err.response.body` where `err` is the `Error` instance.

I don't know. Try to find the difference between the request made by `shopify-api-node` and `curl`. You can use a proxy like Fiddler to do that.

I don't understand this PR. It doesn't use Node.js primordials so what is this protecting against?

Can you show the difference by running eventemitter3 benchmarks before and after the change?

The use of primordials caused performance regressions on Nodes.js not boost https://github.com/nodejs/node/issues/29766.

``` $ node -v v13.7.0 $ cat index.js 'use strict'; const Benchmark = require('benchmark'); const suite = new Benchmark.Suite(); const Arr = Array; let ret; suite.add('local', function() { ret =...