Luigi Pinca

Results 255 comments of Luigi Pinca

Well currently you have an array of arrays. The new config will be an array of objects. Maybe we can check if the first element is an array and determine...

I published [`sauce-browsers`](https://github.com/lpinca/sauce-browsers). It works like this: ```js const browsers = [ { name: 'firefox', version: 50, platform: 'Mac 10.9'}, { name: 'chrome', version: ['oldest', 'latest'] }, { name: 'safari',...

@rtsao yeah I thought that but afaik there is no way to specify the OS in browserlist and it doesn't query Sauce Labs to actually know what browsers are available.

If the spec allows any header I would make it simple and only use a kvp object. I think `validateHeaderName()` and `validateHeaderValue()` from `_http_outgoing.js` can be used to validate the...

I think it makes more sense to undeprecate [`socket.bufferSize`](https://nodejs.org/api/net.html#socketbuffersize) and add `socket._handle.writeQueueSize` to the count instead of adding a new field.

@theanarkh I was talking about `socket.bufferSize` and I meant something like this: ```diff diff --git a/lib/net.js b/lib/net.js index eaa5e594e5..ce02019a75 100644 --- a/lib/net.js +++ b/lib/net.js @@ -637,7 +637,7 @@ ObjectDefineProperty(Socket.prototype, 'bufferSize',...

It seems `socket.bytesWritten = socket._bytesDispatched + socket. + ` so yes it should be correct, but I think it is unnecessarily complex. `socket.writableLength` should take into account `socket. + `...

Superseds https://github.com/nodejs/node/pull/43470.

It seems this only occurs on macOS but I am not able to reproduce locally on macOS 12.4.