Teppo Naakka

Results 8 comments of Teppo Naakka

@mohdsiddique Pinging for heads up, I've fixed your suggestions. The review may continue.

Fixed, all of the conflicts were from my other PR.

I made a decision here that datasets which are not directly used in any report or dashboard, are ingested to Datahub. In the previous implementation those datasets would have been...

I slightly changed course. As I finally realized that our tenant didn't have all the metadata switches enabled, I've now implemented the schema parsing from the scan result. Initially I...

@mohdsiddique I fixed couple of issues in the code, one being Python 3.7 compatibility issue. I think this should be ready for review now. Thank you!

@hsheth2 Yes, it's correct, the #7519 includes an implementation of the PowerBI schema handling too. ~~I have one question though: Is there a test case in #7519 for testing the...

Thank you for the feedback! I'll start working with this asap.

Thank you for the review and feedback! I'll continue working on this still this week.