datahub icon indicating copy to clipboard operation
datahub copied to clipboard

feat(ingest/powerbi): powerbi dataset profiling

Open looppi opened this issue 2 years ago • 3 comments

DAX REST API based profiling implementation to query some details of PowerBI Datasets in the workspace. Does not introduce any breaking changes.

This implementation counts only amount of distinct values, min and max of a column. So it won't completely fulfill the possibilities Datahub UI provides. Extending the implementation to include other metrics isn't very complicated.

Is this something you would like to accept and include in Datahub or is using the DAX API for gathering information considered not a good practice?

Checklist

  • [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [x] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

looppi avatar Nov 30 '23 11:11 looppi

Thank you for the feedback! I'll start working with this asap.

looppi avatar Jan 04 '24 07:01 looppi

@sid-acryl can you take another look at this PR?

hsheth2 avatar Jan 18 '24 22:01 hsheth2

Thank you for the review and feedback! I'll continue working on this still this week.

looppi avatar Feb 28 '24 18:02 looppi