datahub icon indicating copy to clipboard operation
datahub copied to clipboard

feat(ingest): powerbi # add powerbi workspaces to containers

Open looppi opened this issue 3 years ago • 2 comments

Conditionally add PowerBI workspace as a container in ingestion, the implementation then adds all of the entities ingested from the workspace to the container.

The workspace name is not delivered outside from the ingestion phase, so it's not possible to achieve similar behavior with transformation steps.

Configuration defaults to not extracting containers.

Checklist

  • [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [x] Links to related issues (if applicable)
  • [x] Tests for the changes have been added/updated (if applicable)
  • [x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

looppi avatar Nov 23 '22 13:11 looppi

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 51s :stopwatch:    767 tests    765 :heavy_check_mark: 2 :zzz: 0 :x: 1 536 runs  1 531 :heavy_check_mark: 5 :zzz: 0 :x:

Results for commit 0abd0496.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 28 '22 18:11 github-actions[bot]

Unit Test Results (build & test)

621 tests   617 :heavy_check_mark:  15m 37s :stopwatch: 157 suites      4 :zzz: 157 files        0 :x:

Results for commit 0abd0496.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 28 '22 18:11 github-actions[bot]

@mohdsiddique Pinging for heads up, I've fixed your suggestions. The review may continue.

looppi avatar Dec 05 '22 12:12 looppi

Oops - looks like there are conflicts. @mohdsiddique can help you sort any out in Slack before merging :)

jjoyce0510 avatar Jan 18 '23 03:01 jjoyce0510

Fixed, all of the conflicts were from my other PR.

looppi avatar Jan 18 '23 07:01 looppi

Waiting on CI to do final merge. Cheers!

jjoyce0510 avatar Jan 24 '23 03:01 jjoyce0510