Loni Tra

Results 28 comments of Loni Tra

@KlausLoeffelmann gentle ping to keep this on your radar

This PR has not had any activity in a while. Should this still be kept active?

> @lonitra I am unsure who on the team is available to fix it and if we need a separate issue raised? Let's raise a separate issue for this so...

Looks like this was removed in https://github.com/dotnet/winforms/commit/44b5076b843a67ab8497fe73c17576ef3e4dbd99 but this was never fully ported.

@merriemcgaw Cswin32 has to upgrade metadata version in order to address https://github.com/dotnet/winforms/issues/10348, we can shuffle that and https://github.com/dotnet/winforms/issues/9824 to following preview

Closing as there has been no recent activity for some time now. Please feel free to reopen the PR.

@shishiraltysys Can you provide more detailed repro steps so we can understand the scenario a bit more? Ideally a sample project would be helpful here that shows it was working...

@shishiraltysys Thank you for the repro steps! I am able to repro what you are seeing. Looking at the code, I am not so sure we had this working on...

I noticed that we dont have any tests for this either. It might be good to add some basic unit tests for getting the renderer in ToolStripItemTests

@sharwell Looks like there are CI failures, are you able to look into this?