Loni Tra

Results 28 comments of Loni Tra

> What do we do with the following interop libraries? Looping in @JeremyKuhne for further thoughts on this when he's back. For now, we'll proceed with conversions for the other...

> For the issues already raised in win32metadata some of them might not be valid. Could you clarify what you mean when you say that they might not be valid?

``` System.Windows.Forms.UITests.MonthCalendarTests.MonthCalendar_Click_Date_InvokeEventsAsync(delta: 2) [FAIL] Assert.Equal() Failure Expected: 2021-12-03T00:00:00.0000000 Actual: 2021-12-01T00:00:00.0000000 Stack Trace: /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/MonthCalendarTests.cs(100,0): at System.Windows.Forms.UITests.MonthCalendarTests.c__DisplayClass7_0.d.MoveNext() --- End of stack trace from previous location --- /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/Infra/ControlTestBase.cs(240,0): at System.Windows.Forms.UITests.ControlTestBase.c__DisplayClass28_0`1.d.MoveNext() --- End of...

> @lonitra I added the xml comment and renamed the switch to be more specific to its behavior. Thank you! The change looks good. Could you add tests to capture...

> Did we want to change the behavior back, or keep it as is? It used to add in "almost" reverse order, but now it adds it in the order...

It is more difficult to narrow down the cause for this without a callstack, but this test changes the cursor position before doing an assert. https://github.com/dotnet/winforms/blob/9749eb0e0d1b7c992332061133974e0ca6ba6453/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListViewItem.IKeyboardToolTipTests.cs#L717-L718 We are also changing...

Looks like there is some trailing whitespace that is causing build to complain. It is difficult for me to see where on web, but if you build on command line...

@KlausLoeffelmann gentle ping to keep this on your radar to take this to completion

This is awaiting API review. Now that we are in .NET 9, we plan on going through all our API suggestions in the beginning of the new year. Thank you...