winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Modify the accessibility of ToolStripItem's "Renderer" to enable subclasses to set custom renderers and reuse OnPaint logic

Open CuteLeon opened this issue 1 year ago • 1 comments

Fixes #10592

Proposed changes

  • Enhance ToolStripItem to make Renderer accessable

Customer Impact

  • ToolStripItem's Renderer accessable

Regression?

  • No

Risk

  • No

Test methodology

  • This modification is very tiny, and doesn't change default behavior.

Accessibility testing

Microsoft Reviewers: Open in CodeFlow

CuteLeon avatar Jan 05 '24 06:01 CuteLeon

@CuteLeon please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

CuteLeon avatar Jan 09 '24 09:01 CuteLeon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.60136%. Comparing base (c7b6046) to head (cda86b3). Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10593         +/-   ##
===================================================
+ Coverage   74.56221%   74.60136%   +0.03915%     
===================================================
  Files           3041        3041                 
  Lines         629756      629762          +6     
  Branches       46841       46841                 
===================================================
+ Hits          469560      469811        +251     
+ Misses        156831      156585        -246     
- Partials        3365        3366          +1     
Flag Coverage Δ
Debug 74.60136% <100.00000%> (+0.03915%) :arrow_up:
integration 17.96357% <ø> (+0.08685%) :arrow_up:
production 47.53668% <ø> (+0.08630%) :arrow_up:
test 96.97772% <100.00000%> (-0.00024%) :arrow_down:
unit 44.57831% <ø> (+0.00070%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 11 '24 07:07 codecov[bot]

Hi @lonitra, It seems that a unit test failed, but I couldn't find which specific unit test case it was from the concise log. Would you please let me know how to get more detailed unit test logs or locate the failed unit test case? Thanks.

CuteLeon avatar Jul 11 '24 14:07 CuteLeon

I noticed that we dont have any tests for this either. It might be good to add some basic unit tests for getting the renderer in ToolStripItemTests

lonitra avatar Jul 11 '24 18:07 lonitra

I noticed that we dont have any tests for this either. It might be good to add some basic unit tests for getting the renderer in ToolStripItemTests

A unit test of ToolStripItemRenderer_GetReturnsExpected added.

CuteLeon avatar Jul 12 '24 04:07 CuteLeon