lmarceau

Results 117 comments of lmarceau

Build was green [here](https://app.bitrise.io/app/6c06d3a40422d10f/pipelines/2184bf3d-bbb4-4ce4-8253-6287bbaaeb0f), before nits. ![Screen Shot 2022-08-10 at 4 10 52 PM](https://user-images.githubusercontent.com/11338480/184010754-6cbb1858-a6c5-4159-b9c5-e2adacb0237f.png)

Hello! Since this is green and @isabelrios approved in comments, I'll approve and merge it.

@q2r5 Hello! I was tasked to integrate zoom keyboard shortcuts and could take the opportunity to integrate some of your work in PR https://github.com/mozilla-mobile/firefox-ios/pull/9689. I cherry picked your `Tab.swift` zoom...

Hey @q2r5! I have some news about the #7596 ticket. The page action menu will be revisited soon and the zoom feature will be discussed on the design side at...

@q2r5 Just to note, photon sheet rows can now contain more than one action. All actions are now defined in `MainMenuActionHelper`. The zoom actions would be three different `SingleActionViewModel` in...

That's great @q2r5 ! I'll bring this up with our designers so we can get some feedback 👀

Linking Github issue: https://github.com/mozilla-mobile/firefox-ios/issues/11494

@mozead1996 something went wrong, this was a one line change and there's no line change ![Screen Shot 2022-08-10 at 4 15 59 PM](https://user-images.githubusercontent.com/11338480/184011632-1a057ccd-2b74-495b-9d79-5d2413089689.png)

> @lmarceau i updated the file but i see other changes not sure why , i just pulled from the upstream not the fork Indeed, the rebase didn't work. Maybe...

We'll be making a new v104 build shortly that possibly fix this problem