firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

fix: [iPhone] Reload button is not functional after focusing the URL bar #11298

Open mhmdzaid opened this issue 2 years ago • 2 comments

mhmdzaid avatar Jul 19 '22 11:07 mhmdzaid

Thanks for this fix. The URL bar has a lot of interactions with other parts of the code so we are looking to add some tests around this fix to ensure we aren't impacting another area.

jevans-mozilla avatar Jul 21 '22 17:07 jevans-mozilla

This pull request has conflicts when rebasing. Could you fix it @mozead1996?

mergify[bot] avatar Aug 08 '22 18:08 mergify[bot]

@mozead1996 something went wrong, this was a one line change and there's no line change

Screen Shot 2022-08-10 at 4 15 59 PM

lmarceau avatar Aug 10 '22 20:08 lmarceau

@lmarceau i updated the file but i see other changes not sure why , i just pulled from the upstream not the fork

mhmdzaid avatar Aug 10 '22 20:08 mhmdzaid

@lmarceau i updated the file but i see other changes not sure why , i just pulled from the upstream not the fork

Indeed, the rebase didn't work. Maybe best is to create a new PR? Should be quick as this is a one line change.

lmarceau avatar Aug 10 '22 20:08 lmarceau