firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Refactor [v105] FXIOS-4737: Replace more SDWebImage calls with Kingfisher

Open nbhasin2 opened this issue 2 years ago • 1 comments

This replaces direct SDWebimage calls in the following areas with kingfisher

  • Top Tabs
  • Enhanced Tracking Protection
  • Tab Cell
  • Pocket
  • Photon Action Sheet

nbhasin2 avatar Aug 09 '22 20:08 nbhasin2

Moving it to draft to fix some tests

nbhasin2 avatar Aug 09 '22 20:08 nbhasin2

This is good to review, the tests were passing except for the export command and in the last commit, I fixed swift lint rules.

nbhasin2 avatar Aug 10 '22 19:08 nbhasin2

Build was green here, before nits.

Screen Shot 2022-08-10 at 4 10 52 PM

lmarceau avatar Aug 10 '22 20:08 lmarceau