llogiq comments

Results 228 comments of


                                            llogiq

WIP Suggestion creation macro

I still wonder whether the macro is going to pull its weight in terms of complexity. While we have a number of rather complex suggestions, I doubt they add up...

WIP Suggestion creation macro

Sorry for letting you wait, I had a very busy week. This should be good to merge after yet another rebase.

Sorry, I had a busy week. But another question arised: How does this mesh with the new [diagnostics translation effort](https://blog.rust-lang.org/inside-rust/2022/08/16/diagnostic-effort.html) (which may include clippy in the future)?

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

Thank you! r=me with another rebase.

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

Thank you! @bors r+

Fix false positives of needless_match

I think you just need to bless the `needless_match` ui test again ( `cargo dev bless`) and commit+push the resulting diff. (And sorry for being away for so long, thanks...

Fix false positives of needless_match

Thank you! @bors r+

Fix `to_string_in_format_args` false positive

Yes, that's what I meant. Sorry for being absent for a while. r=me after rebase.

Fix `to_string_in_format_args` false positive

Thank you! @bors r+

New `[suspicious_arguments]` lint for possibly swapped arguments

Your call to `fn_arg_names` probably needs a bit more than just a bare `tcx`, as it seems to cause an ICE in the test. I'm not exactly sure why right...