llogiq comments

Results 228 comments of


                                            llogiq

Add new `mixed_attributes_style` lint

Thank you! @bors r+

Add new `mixed_attributes_style` lint

@bors retry

Add new `mixed_attributes_style` lint

@bors r+

FIX(12334): manual_swap auto fix

Thank you! @bors r+

FIX(12334): manual_swap auto fix

@bors retry

FIX(12334): manual_swap auto fix

I think the error is because of `StmtKind::Local` having recently been renamed.

FIX(12334): manual_swap auto fix

Thank you! @bors r+

Missing escping in dump_html

Thanks for letting us know. It'll be a while before I can look into this, but I'll gladly accept PRs.

`Option::as_`(`mut_`)`slice` and `::into_slice`

One open question is whether to split the `into_slice` methods by mutability, having the mutable one named `into_mut_slice`. While this would slightly broaden the API surface, it would reduce the...

`Option::as_`(`mut_`)`slice` and `::into_slice`

Yeah, also https://github.com/rust-lang/rust/blob/65d2f2a5f9c323c88d1068e8e90d0b47a20d491c/compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs#L1437-L1440 and https://github.com/rust-lang/rust/blob/65d2f2a5f9c323c88d1068e8e90d0b47a20d491c/compiler/rustc_hir_typeck/src/place_op.rs#L399-L402 as well as (in bootstrap) https://github.com/rust-lang/rust/blob/65d2f2a5f9c323c88d1068e8e90d0b47a20d491c/src/bootstrap/builder.rs#L865 Should I add another commit to change those implementations (and if I do, will I have to do some...