llogiq
llogiq
Concern: I seem to remember that spans could be zero-sized. A RangeInclusive on the other hand cannot be empty. So why should it be inclusive?
I think I added this when switching to criterion, because I wanted to allow us to enable report generation without requiring it on CI instances (as we only use CI...
That's interesting. I'll do my own benchmarks. I'm not sure if I can allow the additional dependency, given its license.
Also it appears you removed the `avx-accel` feature, which broke the build. If it is no longer needed, we should remove it from the build matrix for both Travis &...
This is really awesome stuff! I like it. I'm still not going to merge it as is. @BurntSushi is one of bytecount major "customers" and ripgrep is a tool I...
On my low-powered skylake machine, which is admittedly not well-suited to benchmarks, with rustc 1.25.0-nightly (bacb5c58d 2018-01-26), your version is consistently slower than the current master with simd-accel (avx-accel is...
So by experimentation I found out that the current working directory is the `target` path of the crate. I got visibility into the error by copying the code into an...
The latter uses a fat pointer+vtable whereas the former does static dispatch, am I right? In that case, it depends on whether you agree to the runtime cost of dynamic...
There is one valid use of `PhantomData` though, when you need to convey that your object has an instance of a type, but don't have the actual owned instance (because...
One can allow for both with specialized constructors, as `Vec` does with `new()` / `with_capacity(_)`.