llogiq

Results 228 comments of llogiq

Another thing to lint against, then... :smile:

The criterion error seems to indicate that the lint fails to apply type adjustments – in this case from `&Vec` to `&[T]` as indicated by the first generic argument of...

Dogfood says no: ``` 2022-10-02T13:08:48.0943209Z Checking clippy_lints v0.1.66 (/home/runner/work/rust-clippy/rust-clippy/clippy_lints) 2022-10-02T13:08:48.0943818Z error: dereferencing a slice pattern where every element takes a reference 2022-10-02T13:08:48.0944250Z --> src/methods/manual_ok_or.rs:25:41 2022-10-02T13:08:48.0944504Z | 2022-10-02T13:08:48.0957818Z 25 | if...

LGTM. Thank you, this approach seems a clear improvement. @bors r+

Luckily Phil Dawes [is busy implementing](http://phildawes.net/blog/2015/06/16/racer-rustc2/) the needed functionality in racer. :smile: Yes, this is just a proof of concept so far, but the feature may not be as far...

I also agree with splitting `MaybeIncorrect`. Perhaps `MayFailToCompile`, `MayChangeBehavior` and `MayBeCounterproductive` (for things that might compile and keep behavior, but not help readability or perf).

We may use the split values for reporting. Users would likely be interested what they should expect. Also if we had a "might not compile, but if it does, it's...

While Qdrant itself is not hosted on crates.io, the Rust client is: https://crates.io/crates/qdrant-client

I think I have an alternative to the movemask dance: If we can afford a pre-loaded `POS_MASK = uint8x16_t(0, 1, 2, 3, 4, ..., 15)`, we can use `vminvq_u8(vorrq_u8(vmvnq_u8(eq), POS_MASK))`...