llogiq

Results 228 comments of llogiq

The fmt test is now successful, but some UI tests fail. Running `cargo dev bless` should make them pass, but I'm not entirely sure that this is the right thing...

Looks good to me. Thank you.

@TheNeikos I think we can merge this after a rebase.

I have the beginning of a RangeSet in the making that could be used for this. I'd just bail on more complex checks (like `a - b > 5`). Non-constant...

Since Samuel has already given a basic review, r? @samueltardieu

Yeah, I guess having `RoaringBitmap::`{`in`, `de`}`crement_range` functions would probably get the most bang for the buck, and could also easily be SIMD-optimized.

Cool! I usually start by writing a test case (create a new .rs file in `tests/ui`, see the other files there for examples). Then I look into where the lint...

This would still be equal to `"Abracadabra".chars().rev().find(..)`. And if you don't care about direction, you can omit the reversal.