Ljubo Nikolić

Results 10 comments of Ljubo Nikolić

Hey @jayofdoom, I've put some comments regarding the current workflow - but in general, as i understand you want to run some EC2 instances, do your tests, and shut down...

this change is obsolete, as repo is marked for archiving

> I get an error installing the chart: `gwilson@macbook ~/P/fasttrackml (pr/845)> helm install fasttrackml ./helm/fasttrackml Error: INSTALLATION FAILED: ConfigMap in version "v1" cannot be handled as a ConfigMap: json: cannot...

> This looks great, thanks for making those changes! Do you think we need to add ingress? (can be new ticket) Thanks, @suprjinx, appreciated 🙏 Originally it makes sense to...

FYI @suprjinx other part of this PR is to publish the chart to the [G-Research/charts](https://github.com/G-Research/charts), after merging this PR we will need to add a few secrets as mentioned and...

hey @suprjinx , could you approve the workflows too? Let me know if anything else is needed to bring this forward 🙏

Hi @suprjinx could you approve PR and hopefully merge this change if not change is required?

FYI: PR for adding `fasttrackml` to G-Research/charts config is merged https://github.com/G-Research/charts/pull/127

FYI `fasttrackml` fingerprint adopted https://github.com/G-Research/charts/pull/130

> I'd prefer to do this the same way we did in [G-Research/spark-extension#201](https://github.com/G-Research/spark-extension/pull/201) and [G-Research/spark-extension#212](https://github.com/G-Research/spark-extension/pull/212). In latest commit, i've applied changes from suggested PRs/commits: - https://github.com/G-Research/spark-extension/pull/212/files - https://github.com/G-Research/spark-extension/commit/0e634c2f827c89d869010473bfc5dad14fb8fb38 p.s format...