armada icon indicating copy to clipboard operation
armada copied to clipboard

WIP: Github Actions running integration tests w/hosted runners

Open jayofdoom opened this issue 2 years ago • 2 comments

jayofdoom avatar Jul 01 '22 21:07 jayofdoom

If statement clearly worked; this will need secrets setup in gr/armada repo for this to pass tests now.

jayofdoom avatar Aug 11 '22 14:08 jayofdoom

Hey @jayofdoom, I've put some comments regarding the current workflow - but in general, as i understand you want to run some EC2 instances, do your tests, and shut down 🤔. I wanted to share with you something that @pavlovic-ivan did and its called ephemeral-github-runner and it's pretty cool and might solve some problems which you also targeting with this PR. Think about it if it's not too complex or out of scope for this PR. Anyway, we are both here to help and support you. If the team agrees that the current workflow should be implemented, I would advise to challenge current security as sharing AWS credentials should be compact and clean 🔒

ljubon avatar Aug 11 '22 18:08 ljubon

~This needs secrets added to g-research/armada in order to run and pass tests and as a prereq to merge.~

Secrets originally created for use with this have been removed.

jayofdoom avatar Aug 17 '22 15:08 jayofdoom