spark-dgraph-connector
spark-dgraph-connector copied to clipboard
Enable Lint check
Checklist before submitting
- [x] Did you read the contributing guide?
- [ ] Did you update the docs?
- [ ] Did you write any tests to validate this change?
Description
The goal of this change is to enable linting as required check for the CI example run: https://github.com/ljubon/spark-dgraph-connector/actions/runs/6946230885/job/18897234201
Fixes # (issue).
Review process for approval
- All tests and other checks must succeed.
- At least one core contributors must review and approve.
- If a core contributor requests changes, they must be addressed.
I'd prefer to do this the same way we did in https://github.com/G-Research/spark-extension/pull/201 and https://github.com/G-Research/spark-extension/pull/212.
Test Results
2 753 files - 243 2 753 suites - 243 49m 41s :stopwatch: - 2m 17s 486 tests ± 0 485 :white_check_mark: ± 0 1 :zzz: ±0 0 :x: ±0 39 807 runs - 3 277 39 719 :white_check_mark: - 3 269 88 :zzz: - 8 0 :x: ±0
Results for commit f259d938. ± Comparison against base commit 09dacbfe.
:recycle: This comment has been updated with latest results.
I'd prefer to do this the same way we did in G-Research/spark-extension#201 and G-Research/spark-extension#212.
In latest commit, i've applied changes from suggested PRs/commits:
- https://github.com/G-Research/spark-extension/pull/212/files
- https://github.com/G-Research/spark-extension/commit/0e634c2f827c89d869010473bfc5dad14fb8fb38
p.s format is not applied, so it's expected that action Linting
is failing - let me know if you want me to commit to this PR formated code which will affect the files in src/
let me know if you want me to commit to this PR formated code which will affect the files in
src/
applied in #264