Luke Emmerson-Finch

Results 58 comments of Luke Emmerson-Finch

@DipperTheDan any chance i could get a hand squashing my commits? I made a right pigs ear of it earlier and managed to pull in 34 file changes (from another...

@edleeks87 or @Parsium - please can i get another review. Aparrently it needs your thumbs up before QA can pick it up.

@rawlmp Can you share the figma so that i can review?

@nicktitchmarsh could this be achieved with the HR component? This way we can restrict the colour of the divider used?

@Parsium i would need to see the design in question that prompted this request. Please could someone share? My gut feel would be to reserve them for particular cases in...

@Parsium I've seen the design for this. It looks like they are wanting to apply specific shadows to a stacked box underneath the sidebar header. To achieve this, perhaps we...

@DipperTheDan Hint text should use the token 'colors.utility.yin.055'. Please can you check this is the case?

@nicktitchmarsh I agree with the expected behaviour proposed here. Otherwise the input will jump around the screen which will be quite jarring for the user. @clairedenning do you agree?

@nicktitchmarsh we should keep the labels and inputs on the same Y-coordinate of the page and push the inputs down as opposed to pushing inputs right. Hope that helps?

@nicktitchmarsh Yes please. So the input's X co-ordinates wouldn't jump around ideally if possible.