carbon icon indicating copy to clipboard operation
carbon copied to clipboard

DateRange validation breaks layout

Open maspychaj-sage opened this issue 2 years ago • 6 comments

Current behaviour

image If validation message is longer than input field than it breaks layout.

Expected behaviour

image Layout should be the same - text should overflow.

CodeSandbox or Storybook URL

https://codesandbox.io/s/reverent-https-xq88p6

JIRA Ticket (Sage Only)

SBS-41049

Suggested Solution

No response

Carbon Version

110.1.1

Design Tokens Version

No response

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

  • [X] I confirm there is no confidential or commercially sensitive information included.

maspychaj-sage avatar Aug 31 '22 09:08 maspychaj-sage

@ljemmo can we have some design input on how to handle this scenario?

nicktitchmarsh avatar Sep 06 '22 13:09 nicktitchmarsh

@nicktitchmarsh I agree with the expected behaviour proposed here. Otherwise the input will jump around the screen which will be quite jarring for the user. @clairedenning do you agree?

ljemmo avatar Sep 06 '22 14:09 ljemmo

Agree!

clairedenning avatar Sep 06 '22 15:09 clairedenning

FE-5368

DipperTheDan avatar Sep 13 '22 13:09 DipperTheDan

@ljemmo for clarificaiton, should we keep the labels and inputs level, or are we ok with things getting pushed around?

nicktitchmarsh avatar Sep 14 '22 09:09 nicktitchmarsh

@nicktitchmarsh we should keep the labels and inputs on the same Y-coordinate of the page and push the inputs down as opposed to pushing inputs right. Hope that helps?

ljemmo avatar Sep 20 '22 14:09 ljemmo

@ljemmo we think it might be possible to keep both the labels and inputs level and flex both the validation areas whilst adding a text wrap. If that isn't possible do we want to keep the labels or the inputs on the same level?

nicktitchmarsh avatar Nov 02 '22 11:11 nicktitchmarsh

@nicktitchmarsh Yes please. So the input's X co-ordinates wouldn't jump around ideally if possible.

ljemmo avatar Nov 02 '22 17:11 ljemmo

:tada: This issue has been resolved in version 111.12.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Dec 01 '22 14:12 carbonci