carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Box having a border prop

Open MarcServat opened this issue 2 years ago • 1 comments

Desired behaviour

Having a prop available to add a border to Box components

Current behaviour

The only way to achieve this is using a FlatTable with one column, which has horizontalBorderSize.

Suggested Solution

<Box bb="1px">Content<Box> or <Box bb="small">Content<Box>

CodeSandbox or Storybook URL

No response

Anything else we should know?

No response

Confidentiality

  • [X] I confirm there is no confidential or commercially sensitive information included.

MarcServat avatar Aug 26 '22 09:08 MarcServat

FE-5335

Parsium avatar Aug 30 '22 12:08 Parsium

@ljemmo are we ok with opening up these props? This might mean people can circumvent the DS approved looks of components and start creating their own with Box

nicktitchmarsh avatar Nov 02 '22 10:11 nicktitchmarsh

@nicktitchmarsh could this be achieved with the HR component? This way we can restrict the colour of the divider used?

ljemmo avatar Nov 02 '22 17:11 ljemmo

@ljemmo After sharing the concerns Nick raised back to @MarcServat, they have spoken with their designer and decided not to go forward with the design that requires this change, so I will close this and FE-5335

Parsium avatar Nov 16 '22 15:11 Parsium