Hongan Li

Results 31 comments of Hongan Li

@jldohmann it looks good to me. Thank you!

Checked with pre-merge testing, the featuregate `IngressControllerLBSubnetsAWS` is enabled by default now, but cannot check the function because the ingresscontroller config `spec.endpointPublishingStrategy.loadBalancer.providerParameters.aws.classicLoadBalancer.subnets` is ignored silently, Also tested in another TP...

/label qe-approved Thanks @gcs278 , after doing `oc apply -f ./0000_50_ingress_00_ingresscontrollers-Default.crd.yaml` then the `.subnets` setting in ingresscontroller works, the annotation is added to LB service. ``` $ oc -n openshift-ingress...

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-azure-aks-ovn-conformance

@lunarwhite could you please help take a look? thanks. cc @xingxingxia

@lunarwhite could you please help take a look? thanks. cc @xingxingxia