openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[WIP] [OSDOCS-3889]: release note for NE-942

Open ShaunaDiaz opened this issue 2 years ago • 5 comments

This is the WIP release note for https://issues.redhat.com/browse/OSDOCS-3889 Engineering story: https://issues.redhat.com/browse/NE-942: Add field in installer to get LB type for AWS

Version(s): PR applies to : 4.12 only

Link to docs preview: https://51186--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ocp-4-12-aws-load-balancer-customization or http://file.rdu.redhat.com/shdiaz/OSDOCS-3889-RN-v2/release_notes/ocp-4-12-release-notes.html#ocp-4-12-aws-load-balancer-customization

Additional information: Docs content is not ready; xref if FPO (for placement only). PR replaces 51174 WIP docs content here: https://github.com/openshift/openshift-docs/pull/51460

QE review:

  • [ ] QE has approved this change.

ShaunaDiaz avatar Oct 04 '22 13:10 ShaunaDiaz

🤖 Updated build preview is available at: https://51186--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/2318

ocpdocs-previewbot avatar Oct 04 '22 14:10 ocpdocs-previewbot

@miheer and @lihongan Please take a look and either approve or suggest revisions. Thank you!

ShaunaDiaz avatar Oct 04 '22 14:10 ShaunaDiaz

@bmcelvee If you'd like to take a look for the ROSA side.

ShaunaDiaz avatar Oct 04 '22 14:10 ShaunaDiaz

/lgtm Thank you!

lihongan avatar Oct 17 '22 11:10 lihongan

@miheer and @Miciah Release note updated to reflect potential change in installation requirement, please review for accuracy.

ShaunaDiaz avatar Oct 18 '22 12:10 ShaunaDiaz

@miheer @Miciah Let's go back to the shorter RN text and I will footnote the table in the docs entry.

ShaunaDiaz avatar Oct 18 '22 14:10 ShaunaDiaz

@miheer @Miciah PTAL and let me know if this PR looks good now.

ShaunaDiaz avatar Oct 19 '22 19:10 ShaunaDiaz

/lgtm

miheer avatar Oct 20 '22 18:10 miheer

/label peer-review-needed

ShaunaDiaz avatar Oct 20 '22 19:10 ShaunaDiaz

Looks like this describes the particulars: https://github.com/openshift/api/pull/1209/files

But that just tells it to create the Ingress Controller with the right LB type. So that API field is in the Ingress API somewhere.

jboxman-rh avatar Oct 21 '22 01:10 jboxman-rh

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Oct 21 '22 19:10 openshift-ci[bot]

/label merge-review-needed

ShaunaDiaz avatar Oct 21 '22 20:10 ShaunaDiaz