openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[WIP] [OSDOCS-3889] add NLB to AWS networking config

Open ShaunaDiaz opened this issue 2 years ago • 2 comments

OSDOCS-3889 WIP PR for review and potential additions.

Version(s):

  • PR applies to: 4.12 only

Issue: NE-942

Link to docs preview: https://51460--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-network-customizations.html#installation-configuration-parameters-optional_installing-aws-network-customizations

https://51460--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-customizations.html#installation-aws-config-yaml_installing-aws-customizations

QE review:

  • [ ] QE has approved this change.

Additional information: https://github.com/openshift/openshift-docs/pull/51186

ShaunaDiaz avatar Oct 10 '22 19:10 ShaunaDiaz

🤖 Updated build preview is available at: https://51460--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/2661

ocpdocs-previewbot avatar Oct 10 '22 19:10 ocpdocs-previewbot

@bscott-rh please take a look @miheer and @lihongan please review and approve or suggest revisions/additions

ShaunaDiaz avatar Oct 10 '22 20:10 ShaunaDiaz

@miheer @Miciah PTAL and let me know if this PR looks good now. Please let me know if there is any additional workflow re: the oc edit ingress.config/cluster -o yaml command having to be run? Want to be sure we don't need additional documentation.

ShaunaDiaz avatar Oct 19 '22 19:10 ShaunaDiaz

/lgtm

miheer avatar Oct 24 '22 17:10 miheer

@lihongan please review and let me know if looks good to your (or suggest revisions/additions)

ShaunaDiaz avatar Oct 24 '22 21:10 ShaunaDiaz

Looks good! Thank you @ShaunaDiaz

lihongan avatar Oct 27 '22 03:10 lihongan

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Oct 27 '22 11:10 openshift-ci[bot]

/label peer-review-needed

ShaunaDiaz avatar Oct 27 '22 11:10 ShaunaDiaz

/remove-label peer-review-needed /label peer-review-in-progress

GroceryBoyJr avatar Oct 27 '22 12:10 GroceryBoyJr

/remove-label peer-review-in-progress /label peer-review-completed

GroceryBoyJr avatar Oct 27 '22 16:10 GroceryBoyJr

@GroceryBoyJr: The label(s) /label peer-review-completed cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, serverless, service-mesh, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label peer-review-in-progress /label peer-review-completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 27 '22 16:10 openshift-ci[bot]

/label peer-review-done

GroceryBoyJr avatar Oct 27 '22 16:10 GroceryBoyJr

/label merge-review-needed

ShaunaDiaz avatar Oct 27 '22 16:10 ShaunaDiaz

/label merge-review-in-progress

michaelryanpeter avatar Oct 27 '22 18:10 michaelryanpeter

/remove-label merge-review-in-progress /remove-label merge-review-needed

michaelryanpeter avatar Oct 27 '22 19:10 michaelryanpeter

/label merge-review-needed

ShaunaDiaz avatar Oct 27 '22 20:10 ShaunaDiaz

@bergerhoffer Yes, it's the crazy ifdefs. I couldn't change them all.

ShaunaDiaz avatar Oct 27 '22 21:10 ShaunaDiaz

/cherrypick enterprise-4.12

bergerhoffer avatar Oct 27 '22 21:10 bergerhoffer

@bergerhoffer: new pull request created: #52252

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.