Liam Cain

- [Handlebars.registerHelper('linkify',](https://github.com/OnlyWorlds/obsidian-plugin/blob/a27db9cb680120d7abed07ecde8e7a8879edce35/main.ts#L44) looks like this is duplicated below - [plugins/obsidian-plugin](https://github.com/OnlyWorlds/obsidian-plugin/blob/a27db9cb680120d7abed07ecde8e7a8879edce35/Commands/ImportWorldCommand.ts#L95) this doesn't look right - [plugins/obsidian-plugin](https://github.com/OnlyWorlds/obsidian-plugin/blob/a27db9cb680120d7abed07ecde8e7a8879edce35/Commands/ImportWorldCommand.ts#L126) these paths aren't going to resolve for users - [fs.write(worldDataPath, worldDataJSON)](https://github.com/OnlyWorlds/obsidian-plugin/blob/a27db9cb680120d7abed07ecde8e7a8879edce35/Commands/CopyWorldCommand.ts#L59) [Prefer the Vault...

Sorry for the long delay getting back to this. Your changes look good to me!

Plugin added here: https://github.com/obsidianmd/obsidian-releases/commit/727da498181fc9b92863b17430979316b79d0192

Hi @tcrouzet I split your 2 plugins into two separate pull requests, but they are both failing validation. If you would like to see them merged into the community plugin...

- [if (!this.settings.privateKey || !this.settings.publicKey) {](https://github.com/muckmuck96/obsidian-file-share/blob/3952e049595d950adc3082661ecdda7e2d9108c8/src/main.ts#L24-L30) you should wrap this inside an [`onLayoutReady`](https://github.com/obsidianmd/obsidian-api/blob/9bb30633586c6649474b2affdf5b87efdd86498f/obsidian.d.ts#L3626) callback to ensure that generating the key doesn't impact Obsidian load time. - [this.ws.send](https://github.com/muckmuck96/obsidian-file-share/blob/3952e049595d950adc3082661ecdda7e2d9108c8/src/core/Socket.ts#L90) this can use...

- [mmersiveTranslate](https://github.com/imfenghuang/obsidian-immersive-translate/blob/f7970924e522311601d2a19ba28744f3211fcb99/src/utils.ts#L25) typo

- [const frontmatterMatch = content.match(frontmatterRegex)](https://github.com/natedog2424/ObsidianLocationDatabase/blob/b9ec8689ee9a40cfab17ab7d862ed28f81d2774a/main.ts#L165) instead of parsing the frontmatter yourself, you should consider using the frontmatter object stored in the metadataCache. `this.app.metadataCache.getFileCache(file).frontmatter?.location` for example. This will avoid false-positives. For...

- [this.registerEvent(this.app.vault.on("create",](https://github.com/leknes/promerge/blob/1af5fcc6740887b366de7264026b58204f8947f4/main.ts#L237) you should wrap all these vault event handlers inside a [`onLayoutReady`](https://github.com/obsidianmd/obsidian-api/blob/9bb30633586c6649474b2affdf5b87efdd86498f/obsidian.d.ts#L3626) callback. As a part of Obsidian's vault initialization process, it will call 'create' for every file. So...

- [Remove Redundant Line Breaks](https://github.com/pablos08/remove-redundant-line-breaks/blob/04c94ab31982d0ea76a88c9e2be8f87cba152e28/main.js#L7) We recommend that all commands use [Sentence case](https://en.wiktionary.org/wiki/sentence_case) for their names. This maximizes readability in the command palette. - [editor.setCursor(cursor);](https://github.com/pablos08/remove-redundant-line-breaks/blob/04c94ab31982d0ea76a88c9e2be8f87cba152e28/main.js#L14) this won't set the cursor...

- [this.app.vault.on("create", this.onCreateFile.bind(this))](https://github.com/LA/obsidian-daily-note-collector/blob/54243029e4f6baacd51dbf7f19f532c29f729803/main.ts#L10) you should not register the 'create' vault event directly in `onload`. This registration should be wrapped inside a [`onLayoutReady`](https://github.com/obsidianmd/obsidian-api/blob/9bb30633586c6649474b2affdf5b87efdd86498f/obsidian.d.ts#L3626) callback. To see why, try restarting Obsidian and...