Liam Cain

Thanks! > > [startPos.ch += 0.5;](https://github.com/cool-RR/backtick-text-selector/blob/80e32c35a67154a2587c2dbba8bb269621ecd898/main.js#L72) what is this for? I don't think codemirror supports fractional positions so I'm not sure where this gets rounded (if it works) > >...

> I spent too long debugging the different cases a while back when I wrote this. I don't remember exactly which case required the += 0.5. Ideally there should be...

- [executeCommandById](https://github.com/Erallie/css-inserter/blob/4def28ea5b5c58188004bdd9d979c547cb3448b3/main.ts#L88) you can easily avoid calling executeCommandById by just pulling the editorCallbacks into their own functions. You already have an editor instance passed in, so you can call this.removeCss(editor)...

joethei@ is still out on sick leave, he can take a look when he gets back, otherwise you can invite me to the repo and I'll take a look today.

Hi, the plugin looks good to me! Your usage of `enable` and `syncing` seems okay. Because I didn't have the right permissions on this branch, I rebased and merged your...

- [this.settingTab = new SettingTab(this.app, this)](https://github.com/tyrad/obsidian-vitepress/blob/35ed82fb88f4a43ea4550655aa2be39e4717e481/src/main.ts#L19) You shouldn't need a reference to this. Just create the setting tab inside onload - [button.detach();](https://github.com/tyrad/obsidian-vitepress/blob/35ed82fb88f4a43ea4550655aa2be39e4717e481/src/main.ts#L98) why are you detaching the existing button? If...

How are the changes coming along? Are you having trouble adding support for pop-out windows? I see the resize event listener is still there too.

> But I still don't understand that there is no popout windows in my plugin and I didn't use "instanceof", why do i have to support and what should I...

- [callback: () => this.printCurrentNote()](https://github.com/gitatmax/printsidian/blob/0364fcce4d9e6ef5c1740cad64540845b6e6c7af/src/main.ts#L21) you should use checkCallback instead and check to see if there is an active markdown file - [const activeView = this.app.workspace.getActiveViewOfType(MarkdownView);](https://github.com/gitatmax/printsidian/blob/0364fcce4d9e6ef5c1740cad64540845b6e6c7af/src/main.ts#L36) you should use [`getActiveFile`](https://github.com/obsidianmd/obsidian-api/blob/38dd22168d2925086371bfc59e36fd9121527a39/obsidian.d.ts#L4146)...

- [await](https://github.com/arkimedz-gh/obsidian-all-tasks-here/blob/5cd739994bba443f54e07a49dbae0520fa9a27fe/main.ts#L83) this await isn't doing anything, you can remove it - [this.app.workspace.getLeavesOfType(VIEW_TYPE_TODO).forEach((leaf) => leaf.detach());](https://github.com/arkimedz-gh/obsidian-all-tasks-here/blob/5cd739994bba443f54e07a49dbae0520fa9a27fe/main.ts#L89)