Liam Cain
Liam Cain
- [activeLeaf.view.sourceMode.cmEditor](https://github.com/ytisf/virustotal-enrich/blob/ce8314aa5be254633d442f6cd54611601cd2c4d7/src/main.js#L383) this is totally unnecessary, you already have a reference to editor on line 371. - [var](https://github.com/ytisf/virustotal-enrich/blob/ce8314aa5be254633d442f6cd54611601cd2c4d7/src/main.js#L402) I recommend you change all instances of `var` to either `const` or...
I still see a lot of instances of `var`. - [const noteTitle = this.app.workspace.getActiveFile().basename](https://github.com/ytisf/virustotal-enrich/blob/886ebee43d2c498131260c6c57c6e5ef08135875/src/main.js#L384) you should be using editor.file?.basename instead - [activeLeaf = this.app.workspace.activeLeaf](https://github.com/ytisf/virustotal-enrich/blob/886ebee43d2c498131260c6c57c6e5ef08135875/src/main.js#L380) why are you checking for an...
Changes look good. But see the error above. Looks like you have the wrong tag on your release Tag needs to match the Obsidian format. So it should be `0.0.4`
Hi! Just checking to see if you saw Joethei's latest comments with requested changes.
I have edited the post to provide a bit more context around what the issue is and why we deemed it severe enough to mark the latest plugin version as...
- [MyPlugin](https://github.com/hjamet/Canvas-Explorer/blob/96bbb3cb615227d19c3d177ca80295271713e0f3/main.ts#L69) you should rename your class - [buttonContainer.style.display = 'flex';](https://github.com/hjamet/Canvas-Explorer/blob/96bbb3cb615227d19c3d177ca80295271713e0f3/main.ts#L272) you should use css classes for this. Better yet, try to reuse the classnames that Obsidian uses for its...
I also noticed that in the README, the commands are in English, however, in the plugin, the commands are in French. I suggest changing one or the other to be...
- [await this.app.vault.modify(activeFile, newContent);](https://github.com/heatherpiper/color-highlighter/blob/17b3e527258de0fd07838eeebe83de99489be08c/main.ts#L196) don't attempt to parse and modify the frontmatter manually. There are race conditions and edge cases that are easy to run into. You should use [`processFrontmatter`]()...
There's no need to keep rebasing, we'll rebase it before we merge it. I'll be focused on plugin reviews later today, so I'll try my best to get to this...
- You can remove the styles.css from the plugin and the plugin release. It's not used. - [startPos.ch += 0.5;](https://github.com/cool-RR/backtick-text-selector/blob/80e32c35a67154a2587c2dbba8bb269621ecd898/main.js#L72) what is this for? I don't think codemirror supports fractional...