Liam Cain
Liam Cain
Thanks for bumping this @nicolasmarc1. Sorry for the long wait. I just released v0.6.6 with the fix.
Hi @cumany, the changes look good and the plugin LGTM 🚀 . There is a small issue with the PR though since you have 2 plugins both submitted from the...
- [const base_url = "https://scybble.ink";](https://github.com/Azeirah/scrybble/blob/a4c615f525ccaf0ba6f69a8df18bd531cc558299/src/sync.ts#L4-L5) Looks like you have a typo here, the url should be https://scrybble.ink, right? - [if (token !== null) {](https://github.com/Azeirah/scrybble/blob/a4c615f525ccaf0ba6f69a8df18bd531cc558299/main.ts#L25-L26) this syncing shouldn't be performed directly...
Looks good! I just left one more small comment: https://github.com/Azeirah/scrybble/commit/54127eb422d1832bba3d9244e468491c1149ce66#r91911841
> I was also somewhat surprised that requestUrl calls don't get recorded in the devtools network tab. I assume you're not using electron's fetch or XMLHttpRequest under the hood, but...
I accept this 🙇 🙇
If you're comfortable with regular expressions at all, this is already possible. This will highlight any word containing "test" (including `protest`, `testing`, `test`...): ``` \w*test\w* ``` Here's the snippet if...
You might want to try out this plugin which does exactly what you're suggesting: https://github.com/hadynz/obsidian-sidekick
Also on 0.5.1. But I can't sense any pattern to it. For me at least, it doesn't seem affected by the length of the path. Also what's weird is that...
I think it should always show the full path for consistency. As for ranking, I'm not sure. Maybe if there was a way to prefer filename matches, that's _probably_ better....