Olena Orobei

[New Rule] Add declare(strict_types=1) to your PHP files

11

### Rule All new PHP files MUST have strict type mode enabled by starting with `declare(strict_types=1)`;. All updated PHP files SHOULD have strict type mode enabled. PHP interfaces SHOULD NOT...

[New Rule] Implement sniff for functions PHPDoc formatting

3

### Rule PHPDoc formatting for functions and methods. **Acceptance Criteria:** - Sniff covers described on [DevDocs requirements](https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html): > **Functions and methods should have:** >A short description in case it adds...

[Proposal] Version specific sniffs

10

### Problem Overview Some of the rules like `strict_types` were introduced in later Magento versions and are not applicable to earlier ones. Magento Marketplace still checks the code of extensions...

Add excludes for test files

5

### Description All rules that do not apply on test files need to have one more exclude. ``` xml */tests/* ``` ### AC - Rules contain additional exclude. - Additional...

[New Rule] Do not use setTemplate in Block classes

5

### Background When creating a Block class, a Block class could set its PHTML template in multiple ways: Through XML layout, through a call to `$this->setTemplate()` and through a variable...

[New Rule] Class instantiation via new keyword

6

### Description `Magento2.Classes.ObjectInstantiation` Detects direct object instantiation via `new` keyword. The test run of `Magento2.Classes.ObjectInstantiation` rule againstMagento2 codebase found >2000 issues. Some of them look like false-positive. Examples: ``` Direct...

Contract for JSON encoding/decoding

6

Since I forgot about https://github.com/magento/architecture/pull/161 and force-pushed to my `master`, creating new PR. Hopefully this PR will get the second wind 🙂 ## Problem The use of JSON data format...

MFTF tests that include user login to adobe stock are failing randomly

1

Fix and unskip the tests that include user login to adobe stock for 1.0-develop and 2.0-develop ### Actual result (*) #1  #2 

Investigate the possibility to move CurrencyPrecision to core

1

CurrencyPrecision module contains logic that might be useful for Magento core. Need to investigate the possibility to move CurrencyPrecision to Magento core. Target version - 2.4.x.

[Documentation] Document Object ManagerSniff

2

Describe why the use of Object Manager is considered as a bad practice. ### Acceptance criteria 1. `ObjectManagerSniff.md` file is created. 2. Explanation about why the use of Object Manager...