magento-coding-standard icon indicating copy to clipboard operation
magento-coding-standard copied to clipboard

Published 20 hours ago • verified publisher icon magento

Add excludes for test files

Open lenaorobei opened this issue 6 years ago • 5 comments
trafficstars

Description

All rules that do not apply on test files need to have one more exclude.

<exclude-pattern>*/tests/*</exclude-pattern>

AC

  • Rules contain additional exclude.
  • Additional PR in https://github.com/magento/magento2 where all false skip annotations are removed. Example: https://github.com/magento/magento2/blob/20db8f67b96e98609ea9d8835ae3830625fa6464/dev/tests/integration/framework/Magento/TestFramework/Workaround/Cleanup/StaticProperties.php#L78

lenaorobei avatar Aug 26 '19 15:08 lenaorobei

Fixed in https://github.com/magento/magento-coding-standard/pull/138

konarshankar07 avatar Aug 31 '19 09:08 konarshankar07

Hello @lenaorobei, I'm still working on creating additional PR in Magento 2 repo where I'll remove false skip annotation Thanks

konarshankar07 avatar Sep 04 '19 16:09 konarshankar07

@konarshankar07 great, it can be done right after new release and dependency update https://github.com/magento/magento2/blob/2.3-develop/composer.json#L90

lenaorobei avatar Sep 04 '19 17:09 lenaorobei

@lenaorobei then I'll wait till the next release

konarshankar07 avatar Sep 04 '19 17:09 konarshankar07

Hello @lenaorobei , Should I start creating the PR in magento 2 repo? Thanks

konarshankar07 avatar Nov 09 '19 18:11 konarshankar07