Luis Enrique Muñoz Martín

Results 204 comments of Luis Enrique Muñoz Martín

I'm currently in maintenance mode on this repo. By now, I'm not developing new features. Sorry! Nevertheless, if anyone wants/can do it I'm open to it.

I really like your implementation. This feature is great to open the door to future extensions. Thanks for your contribution to this!!

Hi @seonwoo960000, It's just a matter of performance improvement. I'm not sure how much it can pump up the performance in real scenarios, to be honest. As far as I...

I close it since there are issues have been created with this info

I think the change is just modifying the above line by the one found in Moonbeam repo at `v0.34.1`: https://github.com/moonbeam-foundation/moonbeam/blob/v0.34.1/Cargo.toml#L224

Thanks for working on this! 🙌🏻 It seems like `v0.35.0` works with polkadot `v1.3.0`. Right now, we're tied to polkadot `v1.1.0`, so we can not move to `v0.35.0` yet

Hi! what's the state of this PR? Is there any solution to the mentioned problem?

I want to add a new point that could be more polemic, but I think it would help a lot to reason about the code: 4. `on_new_data()` should have only...

Why (4) is not compatible with (1)? The resulting signature adding these two points will be: ```rust /// Triggers an event saying that a member has updated the key with...

I think both are the same case because the extrinsic is transactional, so: 1. Values are stored. 2. Notify new value is stored. 3. If the `on_new_data()` rejects, the whole...