Lukas Eklund
Lukas Eklund
Because the gem is binding a single host:port for the metrics server it won't work with `sidekiqswarm` in its current configuration. One option would be to rescue that error and...
@benedictfischer09 I'm sorry I just saw this today when you closed the PR. I think this is a great addition as I've had to filter out OverLimit errors in the...
Perhaps it could be a configurable option so that users could turn off the additional labeling if they expect to have many different label values for the error classes.
I believe the intent of the `lastSuccessfulResponse` was to indicate that the http request to rt.fastly.com succeeded, regardless of the response status code. If, however, this was the intended behavior...
This looks great! Let me know when the new endpoint is ready to go and I can test this branch locally. Thanks for taking care of this!
@mikelorant Sorry this has been sitting for so long. I'll take a look at this early next week.
@mikelorant Thanks for the new PR! I spent some time looking at this today and had some thought/ideas. Left a summary at the top because it got long. ### Summary...
Since my last comment was very long and rambling I thought it might help to put my idea into code: https://github.com/fastly/fastly-exporter/compare/agg-only?expand=1
> On first pass, I totally agree with you on the new approach. My initial implementation was about just setting the datacenter to `aggregated` but I was expecting to be...
> Happy to help with copying the implementation and adding the same code to both origin and domain. Thank you, that would be great! Feel free to copy/modify what I...