sidekiq-prometheus icon indicating copy to clipboard operation
sidekiq-prometheus copied to clipboard

Add error class as label for sidekiq_job_failed

Open leklund opened this issue 5 years ago • 3 comments

It might be useful to have the error class added as a label when a job fails.

leklund avatar May 07 '19 15:05 leklund

That would definitely be very useful! The only thing is this, from the Prometheus docs:

CAUTION: Remember that every unique combination of key-value label pairs represents a new time series, which can dramatically increase the amount of data stored. Do not use labels to store dimensions with high cardinality (many different label values), such as user IDs, email addresses, or other unbounded sets of values.

I don't think we would have that many different errors anyway but it's something to keep an eye on.

DuoSRX avatar May 08 '19 17:05 DuoSRX

Perhaps it could be a configurable option so that users could turn off the additional labeling if they expect to have many different label values for the error classes.

leklund avatar May 08 '19 17:05 leklund

Yeah. Sounds good to me 👍

DuoSRX avatar May 08 '19 20:05 DuoSRX