lberki
lberki
Comments addressed and tests are green. PTAL!
Done and done. PTYAL!
Sigh. It does, but then there is a very similar cycle: 1. `WORKSPACE` 2. `BzlLoadValue` 3. `PackageLookupValue` 4. `IgnoredPackagePrefixesValue` 5. `RepoFileValue` 6. `RepositoryMappingValue` for the repository in which the .bzl...
I'd much rather not gate this behind the removal of WORKSPACE, since that is still a risky thing in my book (less risky than a year ago, but still not...
Closing this in favor of https://github.com/bazelbuild/bazel/pull/24032 ..
Argh. The CI failure seems to be reproducible by `bazel build --nobuild --incompatible_enable_proto_toolchain_resolution @@io_bazel_stardoc//stardoc/proto:stardoc_output_java_proto` My guess: the upgrade to Stardoc also requires an upgrade of `rules_java` on their side so...
> Could you also add the flag here: It's there if you scroll right, on both of these lines :) I haven't looked at the error about invalid escapes, since,...
The Stardoc issue is fixed in https://github.com/bazelbuild/stardoc/pull/237 (I tested the two both). I also managed to reproduce the escaping issue without requiring Windows by the sneaky method of calling `bazel...
Well, I was hoping it'd be a simple thing but turns out, not so; this is my first encounter with the magnificent Velocity Template Language and all my naive attempts...
That is beyond my mandate here, I'm afraid; I was trying to do some adversarial programming to find a way to get a backslash into that string literal, to no...