lberki

Results 220 comments of lberki

FWIW, the proposed solution does not break the dependency cycle because you the proposed `binary_link_deps` attribute could go two ways: 1. It could be of the type `LABEL`. In that...

Uh, sorry. I'll defer to @gregestren here. This seems like a good idea on the surface. You also probably want to give `--incompatible_*` the same treatment.

In principle, adding the functionality to encode spaces in runfiles manifests is fine. I'm not sure, though, how I feel about this particular one because it's tailored to spaces and...

The modified scheme looks reasonable. I'm travelling today so I can't review the pull request but will do so as soon as I can. The main question in my mind...

Actually, managed to skim over the half-sentence asking for the issue to be kept open and it makes total sense. Sorry about that. Bug reopened. It's not an accurate representation...

Do I understand correctly that this increase the size of the Bazel binary only by a single-digit number of megabytes, but the install base by ~50MB? If so, where does...

> the install base is much bigger because it's decompressed from the Bazel binary. I get that. What I'm asking is what does this 50MB of code do. It seems...

I'm afraid I'm not very up-to-date with gRPC and therefore I don't know what the official one-line description _"xDS is the protocol initially used by Envoy, that is evolving into...